tmf: Use query2D for querying histogram #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation does a full query for each requested time. This patch now uses one query2D to calculate the same result. Signed-off-by: Arnaud Fiorini <fiorini.arnaud@gmail.com> Change-Id: Ic84d8a46536718c097de65b4b17df927f9368755
|
This looks great. I would like to know, can we make a helper library with this that can be used for all xy plot data providers? |
|
I do not know if this specific change would be useful for all xy plot, but the DataDrivenXYProviderFactory can be used to create default XY data providers in a few lines of code that specify where to find the data in the state system. |
bhufmann
approved these changes
Feb 13, 2024
MatthewKhouzam
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation does a full query for each requested time. This patch now uses one query2D to calculate the same result.
Change-Id: Ic84d8a46536718c097de65b4b17df927f9368755